Skip to content

Conversation

@yschimke
Copy link
Collaborator

Two effective changes

  • Support for 503, with 0 Retry-After meaning retry automatically
  • Check with 408, and don't do automatic retry if there is a delay

@yschimke
Copy link
Collaborator Author

relates to #3665

@yschimke
Copy link
Collaborator Author

One question is whether Retry-After should be more broadly supported, apart from these two cases

@swankjesse
Copy link
Collaborator

Yeah, I could definitely see us supporting it for 4xx and 5xx responses generally. What do browsers do?

Regardless, this PR is great.

@swankjesse swankjesse merged commit 3a53937 into square:master Dec 31, 2017
@yschimke
Copy link
Collaborator Author

yschimke commented Jan 1, 2018

This PR is mostly me copying and pasting @dave-r12 code from a previous PR

@yschimke yschimke deleted the retry_after branch March 14, 2018 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants